Add "Reviewed by you" filter for pull requests #22927
Conversation
brechtvl
force-pushed
the
blender-filter-approved-by
branch
from
301a687
to
a461e4e
Compare
|
In #16074 a number of other filters are proposed. I think for the home page it makes sense to keep the number of filters limited, both for performance and to avoid clutter. Adding more filters to the Type menu in issue lists on the other hand does not have those problems, so I imagine more could be added there. And so a question is, what is a good set of default filters for the home page, and why should this one be on there? For me the reason is that this makes the pulls that need my attention complete. Having pulls already listed under "created by you" categorized more finely is useful, but I'm usually quite aware of the state of my own pulls. Having pulls filtered by review state regardless of my involvement also is useful, but perhaps would work best to have only in the Type filter menu in a repository. |
GiteaBot
added
the
lgtm/need 2
|
Maybe we need a |
|
I'm not sure what you mean by An alternative here would be to instead add a filter If we do that, the filters together would include all the pull requests that you interacted with, which is the main thing I'm after. It also makes #22926 less important for me, though for issues it would still be nice to somehow see issues that I commented on somewhere. |
|
|
This includes pull requests that you approved, requested changes or commented on. Currently such pull requests are not visible in any of the filters on /pulls, while they may need further action like merging, or prodding the author or reviewers. Especially when working with a large team on a repository it's helpful to get a full overview of pull requests that may need your attention, without having to sift through the complete list.
brechtvl
force-pushed
the
blender-filter-approved-by
branch
from
a461e4e
to
a7e905b
Compare
brechtvl
changed the title
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
|
ping LG-TM bot |
techknowlogick
removed
the
reviewed/wait-merge
* giteaofficial/main: Revert "[skip ci] Updated translations via Crowdin" (go-gitea#23167) [skip ci] Updated translations via Crowdin Return 404 instead of 403 if user can not access the repo (go-gitea#23155) [skip ci] Updated licenses and gitignores Fix secrets overview page missing from docs sidebar (go-gitea#23143) Add "Reviewed by you" filter for pull requests (go-gitea#22927) Projects: rename Board to Column in interface and improve consistency (go-gitea#22767) Fix DBConsistency checks on MSSQL (go-gitea#23132) Add pagination for dashboard and user activity feeds (go-gitea#22937) Update go.mod dependencies (go-gitea#23126) Show empty repos in Admin Repository Management page (go-gitea#23114) Redirect to the commit page after applying patch (go-gitea#23056) Bump go.etcd.io/bbolt and blevesearch deps (go-gitea#23062) Fix height for sticky head on large screen on PR page (go-gitea#23111)
This includes pull requests that you approved, requested changes or commented on. Currently such pull requests are not visible in any of the filters on /pulls, while they may need further action like merging, or prodding the author or reviewers.
Especially when working with a large team on a repository it's helpful to get a full overview of pull requests that may need your attention, without having to sift through the complete list.