-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native error checking with exec.ErrDot
#22735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was meant to land in go-gitea#22073 but was blocked until go-gitea#22732 was merged Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Sorry, misread 😂 |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 3, 2023
Yep, waiting for #22732 to get merged. |
Oh, sorry, I misread, I was thinking about Go 1.20 . 😂 |
delvh
approved these changes
Feb 3, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 3, 2023
zeripath
approved these changes
Feb 3, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 3, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 5, 2023
* giteaoffical/main: (23 commits) Add Cargo package registry (go-gitea#21888) Add new captcha: cloudflare turnstile (go-gitea#22369) add default user visibility to cli command "admin user create" (go-gitea#22750) Show all projects, not just repo projects and open/closed projects (go-gitea#22640) Remove ONLY_SHOW_RELEVANT_REPOS setting (go-gitea#21962) Escape path for the file list (go-gitea#22741) Repositories: by default disable all units except code and pulls on forks (go-gitea#22541) Fix color of tertiary button on dark theme (go-gitea#22739) Refactor git command package to improve security and maintainability (go-gitea#22678) Improve trace logging for pulls and processes (go-gitea#22633) Remove 'primary' class from tab counter labels (go-gitea#22687) Use native error checking with `exec.ErrDot` (go-gitea#22735) update to build with go1.20 (go-gitea#22732) Add missed reverse proxy authentication documentation (go-gitea#22250) Update button is shown when a Pull Request is marked WIP - Issue go-gitea#21740 (go-gitea#22683) Do not overwrite empty DefaultBranch (go-gitea#22708) Improve error report when user passes a private key (go-gitea#22726) Add some comments for recent code (go-gitea#22725) Fix actions workflow branches match bug (go-gitea#22724) Fix group filter for ldap source sync (go-gitea#22506) ...
delvh
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/miscellaneous
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to land in #22073 but was blocked until #22732 was merged