Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more packages to denylist #22412

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Add more packages to denylist #22412

merged 2 commits into from
Jan 12, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Jan 12, 2023

After this, we can remove denylist_imports in gitea-vet (gitea-vet/pulls/23).

deniedImports   = []string{"io/ioutil", "encoding/json", "gitea.com/gitea/go-crypto"}

However, we needn't keep gitea.com/gitea/go-crypto any longer, it's gone and can't be imported again.

@wolfogre wolfogre added this to the 1.19.0 milestone Jan 12, 2023
@wolfogre wolfogre added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 12, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2023
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2023
@lunny
Copy link
Member

lunny commented Jan 12, 2023

make L-G-T-M work

@lunny lunny merged commit c86be81 into go-gitea:main Jan 12, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2023
@wolfogre
Copy link
Member Author

Please review gitea-vet/pulls/23 too.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 13, 2023
* upstream/main:
  Continue GCing other repos on error in one repo (go-gitea#22422)
  improve explore relevancy note (go-gitea#22421)
  fix: don't replace err variable in nested check (go-gitea#22416)
  Add more packages to denylist (go-gitea#22412)
  fix wrong theme class when logged out if default theme is changed (go-gitea#22408)
  Update golang deps (go-gitea#22410)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants