Support system/user default clone editors

[lunny]

Replace #21123
Close #21121
Close #22149

This PR introduces a global configuration named dev.default_editors and a user level configuration named dev.default_editors. Login users will see the menu items from him own configuration and anonymous user will see the menus from global configurations.

Currently, it embeded 3 editors, vscode, vscodium and IDEA. More influent editors and IDE could be added.

TODO:

• Bug: The system options list cannot float over stack div
• Add a user level configuration item to save the default editor.
• Multiple editors support
• Next PRs: Customized editors

Admin panel configuration

User setting configuration

UI in the repository home page

[lafriks]

This should be option to allow select multiple. My use case: on work laptop I use VSCode but on personal laptop I use VSCodium

[lunny]

This should be option to allow select multiple. My use case: on work laptop I use VSCode but on personal laptop I use VSCodium

I will add multiple editors support.

[JakobDev]

Looks nice. I think it should also be possible to use a custom editor in case a User uses some odd editor that is not in the list. You could add a radio button "Use editor from list" which is the current list of your PR and "Use custom editor" where the User can Input a Name, URL and optional a Icon.

[lunny]

Looks nice. I think it should also be possible to use a custom editor in case a User uses some odd editor that is not in the list. You could add a radio button "Use editor from list" which is the current list of your PR and "Use custom editor" where the User can Input a Name, URL and optional a Icon.

That should be next PR for customized editors.

[jolheiser]

Honestly imo this doesn't fix the core issue, it just moves it around.

I think Gitea should allow instance admins to configure whichever they want (and still allow per-user custom anyways)
Each editor in the config would need a name, URL template, and icon URL and this would be more or less fully customizable without opening the door for an ever-growing list like webhooks.

[lunny]

Honestly imo this doesn't fix the core issue, it just moves it around.

I think Gitea should allow instance admins to configure whichever they want (and still allow per-user custom anyways) Each editor in the config would need a name, URL template, and icon URL and this would be more or less fully customizable without opening the door for an ever-growing list like webhooks.

That's what's the next step to do.

[codecov-commenter]

Codecov Report

Merging #22378 (1dfcab4) into main (477a1cc) will increase coverage by 48.17%.
The diff coverage is 20.39%.

@@            Coverage Diff            @@
##           main   #22378       +/-   ##
=========================================
+ Coverage      0   48.17%   +48.17%     
=========================================
  Files         0     1045     +1045     
  Lines         0   142503   +142503     
=========================================
+ Hits          0    68645    +68645     
- Misses        0    65680    +65680     
- Partials      0     8178     +8178     

Impacted Files	Coverage Δ
modules/templates/helper.go	44.55% <0.00%> (ø)
modules/util/slice.go	81.35% <0.00%> (ø)
routers/web/admin/config.go	21.46% <0.00%> (ø)
routers/web/user/setting/profile.go	31.86% <0.00%> (ø)
services/dev/editor.go	29.41% <29.41%> (ø)
modules/context/repo.go	52.90% <33.33%> (ø)
routers/web/web.go	84.60% <42.85%> (ø)
models/user/setting.go	66.14% <66.66%> (ø)
modules/repository/generate.go	32.58% <0.00%> (ø)
models/issues/issue_lock.go	0.00% <0.00%> (ø)
... and 1042 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[lunny]

@yardenshoham @lafriks Both done.

[goyalyashpal]

My use case: on work laptop I use VSCode but on personal laptop I use VSCodium
- lafriks at #22378 (comment)

• How about making it to be tie-able to the local system?
• So, some option like:
  Allow different default on each browser instance or
  Allow device specific preference
• ... similar to how theme settings in various sites (github, youtube, etc) are not tied to the global account settings, but rather tie only to a particular browser instance (i guess using cookies or what not?)

Reference

vivaldi_pKV6RbHvOb.mp4

[lunny]

My use case: on work laptop I use VSCode but on personal laptop I use VSCodium

• lafriks at #22378 (comment)

• How about making it to be tie-able to the local system?
• So, some option like:
  Allow different default on each browser instance or
  Allow device specific preference
• ... similar to how theme settings in various sites (github, youtube, etc) are not tied to the global account settings, but rather tie only to a particular browser instance (i guess using cookies or what not?)

Reference

vivaldi_pKV6RbHvOb.mp4

How could we know the users' editors within the webbrowser?

[lafriks]

As I commented also in other PR, I don't see from current UI perspective much of the problem if in menu I have one option (Open in xxx editor) or multiple, so I don't see how that would make it much easier to use it if default editor would be selected per browser?

[goyalyashpal]

How could we know the users' editors within the webbrowser?

we don't need to, we only need to know all their preferences (which per will enter) and which one to pick on that particular webbrowser (which again, the user will select perself ofcourse).

After that, that editor will be shown in the repos etc as default.

[silverwind]

Needs a rebase

[wxiaoguang]

I guess this PR is not mature yet (the implement doesn't seem maintainable for future).

[silverwind]

Maybe non-ui config would be simpler to implement, e.g. #21121 (comment). Downside is only admin can change it.

[wxiaoguang]

-> Customizable "Open with" applications for repository clone #29320

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines