Skip to content

JS refactors #22227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

JS refactors #22227

merged 1 commit into from
Dec 23, 2022

Conversation

silverwind
Copy link
Member

  • Replace all default exports with named exports, except for Vue SFCs
  • Remove names from Vue SFCs, they are automatically inferred from the filename
  • Misc whitespace-related tweaks

@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 23, 2022
@silverwind silverwind added this to the 1.19.0 milestone Dec 23, 2022
@silverwind
JS refactors
fc910cc 
- Replace all default exports with named exports, except for Vue SFCs
- Remove names from Vue SFCs, they are automatically inferred from the
  filename
- Misc whitespace-related tweaks
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 23, 2022
@lunny lunny merged commit 2cf0cf0 into go-gitea:main Dec 23, 2022
@silverwind silverwind deleted the jsfmt branch December 23, 2022 18:34
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 26, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
7a1855d 
* upstream/main:
  Add Mermaid copy button, avoid unnecessary tooltip hide (go-gitea#22225)
  [skip ci] Updated licenses and gitignores
  Improve testing for pgsql empty repository (go-gitea#22223)
  JS refactors (go-gitea#22227)
  Check primary keys for all tables and drop ForeignReference (go-gitea#21721)
@AbdulrhmnGhanem AbdulrhmnGhanem mentioned this pull request Dec 30, 2022
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @KN4CK3R @GiteaBot