-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added space between avatar and username #21825
Merged
techknowlogick
merged 3 commits into
go-gitea:main
from
MayMeow:dev/add-space-after-avatar
Nov 15, 2022
Merged
Added space between avatar and username #21825
techknowlogick
merged 3 commits into
go-gitea:main
from
MayMeow:dev/add-space-after-avatar
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
reviewed
Nov 15, 2022
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 15, 2022
silverwind
reviewed
Nov 15, 2022
Co-authored-by: silverwind <me@silverwind.io>
zeripath
approved these changes
Nov 15, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 15, 2022
jolheiser
approved these changes
Nov 15, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 15, 2022
silverwind
approved these changes
Nov 15, 2022
ping lg-tm |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 16, 2022
* giteaofficial/main: Added space between avatar and username (go-gitea#21825) Skip GitHub migration tests if the API token is undefined (go-gitea#21824) Add `updated_at` field to PullReview API object (go-gitea#21812) Adjust gitea doctor --run storages to check all storage types (go-gitea#21785) Remove `href="javascript:;"` in "save topics (Done)" button (go-gitea#21813) Improve pull/ push mirror documentation (especially for GitHub) (go-gitea#21801)
fsologureng
pushed a commit
to fsologureng/gitea
that referenced
this pull request
Nov 22, 2022
Added space between avatar and username which is missing on verified commit message and avatar is too close to username which is don't look nice. Current state ![image](https://user-images.githubusercontent.com/3164256/202007728-d7d6ecac-f754-454c-a67f-e422f4aac5a5.png) This is how it looks after change ![image](https://user-images.githubusercontent.com/3164256/202007984-d4a38a1c-7c24-4278-aa0f-9aa51c10f772.png) Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added space between avatar and username which is missing on verified commit message and avatar is too close to username which is don't look nice.
Current state
This is how it looks after change