Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added space between avatar and username #21825

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

MayMeow
Copy link
Contributor

@MayMeow MayMeow commented Nov 15, 2022

Added space between avatar and username which is missing on verified commit message and avatar is too close to username which is don't look nice.

Current state
image

This is how it looks after change
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2022
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Nov 15, 2022
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2022
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit f311d15 into go-gitea:main Nov 15, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 16, 2022
* giteaofficial/main:
  Added space between avatar and username (go-gitea#21825)
  Skip GitHub migration tests if the API token is undefined (go-gitea#21824)
  Add `updated_at` field to PullReview API object (go-gitea#21812)
  Adjust gitea doctor --run storages to check all storage types (go-gitea#21785)
  Remove `href="javascript:;"` in "save topics (Done)" button (go-gitea#21813)
  Improve pull/ push mirror documentation (especially for GitHub) (go-gitea#21801)
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
Added space between avatar and username which is missing on verified
commit message and avatar is too close to username which is don't look
nice.

Current state

![image](https://user-images.githubusercontent.com/3164256/202007728-d7d6ecac-f754-454c-a67f-e422f4aac5a5.png)


This is how it looks after change

![image](https://user-images.githubusercontent.com/3164256/202007984-d4a38a1c-7c24-4278-aa0f-9aa51c10f772.png)

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants