Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user webhooks #21563

Merged
merged 30 commits into from
Mar 10, 2023
Merged

Add user webhooks #21563

merged 30 commits into from
Mar 10, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Oct 23, 2022 •
edited
Loading

Currently we can add webhooks for organizations but not for users. This PR adds the latter. You can access it from the current users settings.

grafik

@KN4CK3R KN4CK3R added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 23, 2022
@KN4CK3R KN4CK3R added this to the 1.19.0 milestone Oct 23, 2022
@lunny
Copy link
Member

lunny commented Nov 5, 2022

Please resolve conflicts.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 5, 2022
lunny
lunny reviewed Nov 21, 2022
View reviewed changes
routers/web/web.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Nov 21, 2022
View reviewed changes
routers/web/web.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Nov 24, 2022

Please resolve the conflicts

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2022
zeripath
zeripath reviewed Dec 4, 2022
View reviewed changes
routers/api/v1/utils/hook.go Outdated Show resolved Hide resolved
routers/api/v1/utils/hook.go Show resolved Hide resolved
routers/api/v1/user/hook.go Outdated Show resolved Hide resolved
routers/web/user/setting/webhooks.go Outdated Show resolved Hide resolved
templates/user/settings/navbar.tmpl Show resolved Hide resolved
routers/web/web.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2023
@zeripath
Copy link
Contributor

zeripath commented Feb 6, 2023

it looks like CI failure is related.

@delvh delvh mentioned this pull request Feb 19, 2023
Merged
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2023
@delvh
Copy link
Member

delvh commented Feb 19, 2023

Well…
You accidentally deleted the migration with the merge.

@delvh delvh removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2023
@delvh delvh modified the milestones: 1.19.0, 1.20.0 Feb 20, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 10, 2023
@lunny
Copy link
Member

lunny commented Mar 10, 2023

CI failure is related.

@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 2173f14 into go-gitea:main Mar 10, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 10, 2023
@KN4CK3R KN4CK3R deleted the feature-user-webhooks branch March 10, 2023 14:30
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
41d6ad0 
* giteaofficial/main:
  Scoped label display and documentation tweaks (go-gitea#23430)
  Deduplicate template code for label selection menu (go-gitea#23431)
  Show edit/close/delete button on organization wide repositories (go-gitea#23388)
  Sync the class change of Edit Column Button to JS code (go-gitea#23400)
  Preserve file size when creating attachments (go-gitea#23406)
  [skip ci] Updated translations via Crowdin
  Use buildkit for docker builds (go-gitea#23415)
  Refactor branch/tag selector dropdown (first step) (go-gitea#23394)
  [skip ci] Updated translations via Crowdin
  Hide target selector if tag exists when creating new release (go-gitea#23171)
  Parse external request id from request headers, and print it in access log (go-gitea#22906)
  Add missing tabs to org projects page (go-gitea#22705)
  Add user webhooks (go-gitea#21563)
  Handle OpenID discovery URL errors a little nicer when creating/editing sources (go-gitea#23397)
  Split CI pipelines (go-gitea#23385)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@KN4CK3R @lunny @codecov-commenter @zeripath @delvh @jolheiser @GiteaBot