Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to frontend guidelines in hacking guidelines #21382

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Fix broken link to frontend guidelines in hacking guidelines #21382

merged 2 commits into from
Oct 12, 2022

Conversation

yardenshoham
Copy link
Member

Previously the link was broken on the hugo-generated site

When clicking here
image
you'd get
image

Signed-off-by: Yarden Shoham hrsi88@gmail.com

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 9, 2022
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ea3c6c6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #21382   +/-   ##
=======================================
  Coverage        ?   47.44%           
=======================================
  Files           ?     1020           
  Lines           ?   139037           
  Branches        ?        0           
=======================================
  Hits            ?    65961           
  Misses          ?    65086           
  Partials        ?     7990           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 11, 2022
Previously the link was broken on the hugo-generated site

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@techknowlogick techknowlogick merged commit b5a54f0 into go-gitea:main Oct 12, 2022
@yardenshoham yardenshoham deleted the docs branch October 12, 2022 09:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 13, 2022
* upstream/main: (25 commits)
  [skip ci] Updated translations via Crowdin
  Respect user's locale when rendering the date range in the repo activity page (go-gitea#21410)
  Consolidate more CSS colors into variables (go-gitea#21402)
  Add HEAD fix to gitea doctor (go-gitea#21352)
  Contribution guidelines (go-gitea#21425)
  Refactor Gitpod configuration to improve quick spin up of automated dev environments (go-gitea#21411)
  Support instance-wide OAuth2 applications (go-gitea#21335)
  Case-insensitive NuGet symbol file GUID (go-gitea#21409)
  Add generic set type (go-gitea#21408)
  Improve OAuth integration tests (go-gitea#21390)
  Make e-mail sanity check more precise (go-gitea#20991)
  Fix broken link to frontend guidelines in hacking guidelines (go-gitea#21382)
  Use Name instead of DisplayName in LFS Lock (go-gitea#21415)
  [skip ci] Updated translations via Crowdin
  feat(pr review): add more space on mobile (go-gitea#21326)
  Bump `golang.org/x/text` (go-gitea#21412)
  Update gitea.service (go-gitea#21399)
  Do DB update after merge in hammer context (go-gitea#21401)
  add gitpod config (go-gitea#20995)
  Remove cancel button in repo creation page (go-gitea#21381)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants