Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add branch overiew page #2108

Merged
merged 4 commits into from
Oct 26, 2017
Merged

Add branch overiew page #2108

merged 4 commits into from
Oct 26, 2017

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Jul 3, 2017 •
edited by lunny
Loading

Todo:

Part 1:

  • Overview page
  • Delete branch
  • Undo delete
  • Add tests

Part 2: SHOULD be another PR

  • Rename branch
  • Create branch
  • Add notifications
  • Mark branch as deleted after merge delete

Preview:
Preview

@Bwko Bwko force-pushed the branch_overview branch 2 times, most recently from 9e46ede to 9ea9347 Compare July 3, 2017 21:09
lafriks
lafriks reviewed Jul 3, 2017
View reviewed changes
routers/repo/branch.go Outdated
branchName := ctx.Query("name")

defer func() {
redirectTo := ctx.Query("redirect_to")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need redirect_to from post? It is known that it will allways be branch overview page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I'll delete the redirect param

@lunny lunny added this to the 1.x.x milestone Jul 4, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jul 4, 2017
@Bwko Bwko force-pushed the branch_overview branch 22 times, most recently from cb43736 to a75985b Compare July 8, 2017 22:01
@Bwko Bwko changed the title *WIP* Add branch overiew page Add branch overiew page Jul 8, 2017
@Bwko
Copy link
Member Author

Bwko commented Jul 8, 2017

Part 1 is done 🎉 😃

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2017
@Bwko Bwko force-pushed the branch_overview branch 2 times, most recently from f00d6ef to 7ccdb01 Compare July 28, 2017 20:11
@lunny lunny mentioned this pull request Sep 15, 2017
Closed
@lunny
Copy link
Member

lunny commented Sep 15, 2017

@Bwko please rebase maybe this is ready for review and merge.

@lunny lunny modified the milestones: 1.x.x, 1.3.0 Sep 15, 2017
@lunny
Copy link
Member

lunny commented Sep 21, 2017

will replace #2464

@codecov-io
Copy link

codecov-io commented Sep 21, 2017 •
edited
Loading

Codecov Report

Merging #2108 into master will increase coverage by 0.15%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
+ Coverage   27.08%   27.23%   +0.15%     
==========================================
  Files          88       88              
  Lines       17264    17333      +69     
==========================================
+ Hits         4676     4721      +45     
- Misses      11909    11927      +18     
- Partials      679      685       +6
Impacted Files Coverage Δ
models/models.go 29.16% <100%> (+0.32%) ⬆️
models/branches.go 21.59% <55.88%> (+21.59%) ⬆️
models/user.go 22.11% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86a0bf...6f0c294. Read the comment docs.

@OmarAssadi OmarAssadi mentioned this pull request Oct 19, 2017
Closed
@lafriks
Copy link
Member

lafriks commented Oct 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2017
@lunny
Copy link
Member

lunny commented Oct 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 26, 2017
@lunny lunny merged commit 3ab580c into go-gitea:master Oct 26, 2017
@Bwko Bwko deleted the branch_overview branch October 26, 2017 09:47
vdbt pushed a commit to vdbt/gitea that referenced this pull request Oct 27, 2017
@Bwko @vdbt
Add branch overiew page (go-gitea#2108)
d398cfb 
* Add branch overiew page

* fix changed method name on sub menu

* remove unused code
@lunny
Copy link
Member

lunny commented Dec 7, 2017

partially resolved #307

@bkcsoft bkcsoft mentioned this pull request May 1, 2018
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkcsoft bkcsoft bkcsoft left review comments

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Bwko @lafriks @lunny @codecov-io @bkcsoft @tboerger