Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input.value attr for RequiredClaimName/Value #20946

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Fix input.value attr for RequiredClaimName/Value #20946

merged 3 commits into from
Aug 25, 2022

Conversation

soumyadey
Copy link
Contributor

Values set for RequiredClaimName and RequiredClaimValue do not show up on UI.
Fix typo values to value.

Issue link: #20945

Values set for RequiredClaimName and RequiredClaimValue do not show up on UI.
Fix typo `values` to `value`.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2022
@lunny lunny added type/bug backport/v1.17 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 25, 2022
@zeripath
Copy link
Contributor

Make lgtm work

@zeripath zeripath merged commit a2db810 into go-gitea:main Aug 25, 2022
@zeripath
Copy link
Contributor

Please send backport

zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 25, 2022
* upstream/main:
  Fix input.value attr for RequiredClaimName/Value (go-gitea#20946)
  Move some files into models' sub packages (go-gitea#20262)
  [skip ci] Updated translations via Crowdin
  docs[zh-cn]: Install on Kubernetes (go-gitea#20874)
  Return 404 NotFound if requested attachment does not exist (go-gitea#20886)
  Avoid frequent string2bytes conversions (go-gitea#20940)
@soumyadey soumyadey deleted the patch-1 branch August 26, 2022 08:58
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
Values set for RequiredClaimName and RequiredClaimValue do not show up on UI.
Fix typo `values` to `value`.
jolheiser pushed a commit to jolheiser/gitea that referenced this pull request Aug 30, 2022
Values set for RequiredClaimName and RequiredClaimValue do not show up on UI.
Fix typo `values` to `value`.
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Aug 30, 2022
jolheiser added a commit that referenced this pull request Aug 31, 2022
Values set for RequiredClaimName and RequiredClaimValue do not show up on UI.
Fix typo `values` to `value`.

Co-authored-by: soumyadey <soumya.dey@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 7, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants