Skip to content

Fix SQL bug in models.PullRequests #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2017
Merged

Fix SQL bug in models.PullRequests #2092

merged 1 commit into from
Jul 1, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jul 1, 2017 •
edited
Loading

Fixes the GET /repos/:owner/:repo/pulls API endpoint, which previously gave a 500 on Postgres.

Postgres doesn't like ORDER BY clauses in SELECT COUNT(*) ... queries.

Also add an integration test.

@lunny lunny added this to the 1.2.0 milestone Jul 1, 2017
@lunny lunny added the type/bug label Jul 1, 2017
@lunny
Copy link
Member

lunny commented Jul 1, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 1, 2017
@Bwko
Copy link
Member

Bwko commented Jul 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2017
@lafriks lafriks merged commit eae9154 into go-gitea:master Jul 1, 2017
@ethantkoenig ethantkoenig deleted the fix/pull_api branch July 1, 2017 23:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ethantkoenig @lunny @Bwko @tboerger @lafriks