Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL Query for SearchTeam (#20844) #20872

Merged
merged 4 commits into from
Aug 21, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Aug 20, 2022

- Backport of go-gitea#20844
  - Currently the function takes in the UserID option, but isn't being used within the SQL query. This patch fixes that by checking that only teams are being returned that the user belongs to.
  - Resolves go-gitea#20829
@Gusted Gusted added this to the 1.17.2 milestone Aug 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 20, 2022
@delvh
Copy link
Member

delvh commented Aug 20, 2022

Ah wait, why is the CI complaining? user17.Name unknown?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 20, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Aug 21, 2022

Ah wait, why is the CI complaining? user17.Name unknown?

Small copy paste error caused by #20797 shall be all good now.

@zeripath zeripath merged commit e6ec411 into go-gitea:release/v1.17 Aug 21, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants