docs: move search input to navbar #20551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noerw
added
type/docs
This comment was marked as outdated.
This comment was marked as outdated.
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jul 31, 2022
GiteaBot
added
lgtm/need 1
Gusted
approved these changes
Aug 1, 2022
GiteaBot
added
lgtm/done
|
Not a problem with this PR, but the input text is off-center vertically. Likely has something to do with the percentage height (generally percentages should be avoided in CSS):
|
|
@silverwind I don't know how to fix that. I have spent hours (days?) in the past trying to vertically align inputs across browsers and have given up at this point. If you know how to fix that I'd be happy to learn 🙃 |
|
Looks fine on my machine :P |
|
It seems no more suggestions since 6 days ago. Ready to merge |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 9, 2022
* giteaofficial/main: Add support for `npm unpublish` (go-gitea#20688) Allow multiple files in generic packages (go-gitea#20661) Refactor legacy git init (go-gitea#20376) Fix typo in source (go-gitea#20723) [skip ci] Updated translations via Crowdin Add issue filter for Author (go-gitea#20578) Fix init mail render logic (go-gitea#20704) Frontport changelog v1.17.0 (go-gitea#20712) Fix disable download button (go-gitea#20701) docs: move search input to navbar (go-gitea#20551) Fix SecToTime edge-cases (go-gitea#20610)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
* remove search item from sidebar * fix search for some docs languages Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
delvh
added
topic/ui-interaction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the search input was on a dedicated search page, being rather unwieldy.
depends on https://gitea.com/gitea/theme/pulls/112