Prevent context deadline error propagation in GetCommitsInfo (#20346) #20361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a#20346) * Prevent context deadline error propagation in GetCommitsInfo Although `WalkGitLog` tries to test for `context.DeadlineExceededErr` there is a small chance that the error will propagate to the reader before it is recognised. This will cause the error to propagate up to `renderDirectoryFiles` and cause a http status 500. Here we check that the error passed is a `DeadlineExceededErr` via error.Is Fix go-gitea#20329 Signed-off-by: Andrew Thornton <art27@cantab.net>
This was referenced Jul 13, 2022
Merged
Gusted
approved these changes
Jul 14, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Jul 14, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #20346
Although
WalkGitLogtries to test forcontext.DeadlineExceededErrthere is a small chance that the error will propagate to the reader
before it is recognised. This will cause the error to propagate up to
renderDirectoryFilesand cause a http status 500.Here we check that the error passed is a
DeadlineExceededErrvia errors.IsFix #20329
Signed-off-by: Andrew Thornton art27@cantab.net