Add missing return for when topic isn't found #20351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Jul 13, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Jul 13, 2022
GiteaBot
added
lgtm/done
zeripath
approved these changes
Jul 13, 2022
|
Please send backport |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 14, 2022
* giteaofficial/main: Fix icon margin in user/settings/repos (go-gitea#20281) Fix org label open count, including close count issue (go-gitea#20353) [skip ci] Updated translations via Crowdin Prevent context deadline error propagation in GetCommitsInfo (go-gitea#20346) Add missing return for when topic isn't found (go-gitea#20351) Upgrade to Node 18 on CI (go-gitea#20340) Fix checks in PR for empty commits go-gitea#19603 (go-gitea#20290) Use default values when provided values are empty (go-gitea#20318) Add tests for the host checking logic, clarify the behaviors (go-gitea#20328) Changelog for 1.16.9 (update) (go-gitea#20341) (go-gitea#20343) Fix various typos (go-gitea#20338) Correctly handle draft releases without a tag (go-gitea#20314) Add write check for creating Commit status (go-gitea#20332) Remove blue text on migrate page (go-gitea#20273) Updated dead link to Madeleine.js source (go-gitea#20322)
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Jul 17, 2022
Backport go-gitea#20351 Add missing return to DeleteTopic API when the topic is not found.
lunny
pushed a commit
that referenced
this pull request
Jul 18, 2022
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Add missing return to DeleteTopic API when the topic is not found.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing return to DeleteTopic API when the topic is not found.