Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove file on initial comment #20127

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Fix remove file on initial comment #20127

merged 3 commits into from
Jun 25, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 24, 2022

Fix remove file on initial comment
6e22707 
- Store the file uuid(which is returned by Gitea in the upload file
response) onto the file object, so it can be used for the remove feature
to specify this file.
- Resolves go-gitea#20115
@Gusted Gusted added this to the 1.18.0 milestone Jun 24, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request Jun 24, 2022
Fix remove file on initial comment (go-gitea#20127)
f7bb744 
- Backport go-gitea#20127
  - Store the file uuid(which is returned by Gitea in the upload file response) onto the file object, so it can be used for the remove feature to specify this file.
  - Resolves go-gitea#20115
@Gusted Gusted mentioned this pull request Jun 24, 2022
Merged
delvh
delvh approved these changes Jun 24, 2022
View reviewed changes
web_src/js/features/common-global.js Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 24, 2022
wxiaoguang
wxiaoguang approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is a File class. Although it's not good to change its properties, but that was what Dropzone did before, and the related code was already quite hacky. So it's fine to get it fixed by file.uuid = xxx.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2022
@Gusted Gusted added the backport/done All backports for this PR have been created label Jun 25, 2022
@zeripath zeripath merged commit a8cdea0 into go-gitea:main Jun 25, 2022
zeripath pushed a commit that referenced this pull request Jun 25, 2022
Fix remove file on initial comment (#20127) (#20128)
0b7b342 
Backport #20127

Store the file uuid(which is returned by Gitea in the upload file response) onto the file object, so it can be used for the remove feature to specify this file.

Fix #20115
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 26, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e4b7cf7 
* giteaofficial/main:
  Use neutral language in comments and docs (go-gitea#20135)
  Fix remove file on initial comment (go-gitea#20127)
  Add doctor command to write commit-graphs (go-gitea#20007)
  Add sitemap support (go-gitea#18407)
  Use new config options (go-gitea#20125)
  Remove depricated queue indexer usage (go-gitea#20124)
  Disable status checks in template if none found (go-gitea#20088)
  Fix typos related to ErrTaskDoesNotExist error (go-gitea#20118)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Fix remove file on initial comment (go-gitea#20127)
770ddd5 
Store the file uuid(which is returned by Gitea in the upload file
response) onto the file object, so it can be used for the remove feature
to specify this file.

Fix go-gitea#20115
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Upload file and click remove file has js error
5 participants
@Gusted @wxiaoguang @delvh @zeripath @GiteaBot