Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DisplayName() instead of FullName in Oauth Provider #19991

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

oGi4i
Copy link
Contributor

@oGi4i oGi4i commented Jun 16, 2022

Use DisplayName() in Oauth as this provides a fallback if FullName is not set.

Closes #19382

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 16, 2022
@techknowlogick techknowlogick added this to the 1.17.0 milestone Jun 16, 2022
@zeripath zeripath changed the title Fix oauth user info name Use DisplayName() instead of FullName in Oauth Jun 16, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2022
@zeripath zeripath merged commit 9068c78 into go-gitea:main Jun 16, 2022
@zeripath zeripath changed the title Use DisplayName() instead of FullName in Oauth Use DisplayName() instead of FullName in Oauth Provider Jun 16, 2022
@oGi4i oGi4i deleted the issue-19382 branch June 17, 2022 06:29
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Use DisplayName() in Oauth as this provides a fallback if FullName is not set.

Closes go-gitea#19382
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Use DisplayName() in Oauth as this provides a fallback if FullName is not set.

Closes go-gitea#19382
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth userinfo empty name fallback
5 participants