Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure responses are context.ResponseWriters #19843

Merged

Commits on May 30, 2022

  1. Ensure responses are context.ResponseWriters

    In order for web.Wrap to be able to detect if a response has been written
    we need to wrap any non-context.ResponseWriters as a such. Otherwise
    responses will be incorrectly detected as non-written to and handlers can
    double run.
    
    In the case of GZip this handler will change the response to a non-context.RW
    and this failure to correctly detect response writing causes fallthrough and
    a NPE.
    
    Fix go-gitea#19839
    
    Signed-off-by: Andrew Thornton <art27@cantab.net>
    zeripath committed May 30, 2022
    Configuration menu
    Copy the full SHA
    acba3b9 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Configuration menu
    Copy the full SHA
    ebe29be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfcedde View commit details
    Browse the repository at this point in the history