Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some repository related code into sub package #19711

Merged
merged 15 commits into from
Jun 6, 2022
Merged

Move some repository related code into sub package #19711

merged 15 commits into from
Jun 6, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented May 15, 2022

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 15, 2022
@6543 6543 added this to the 1.17.0 milestone May 16, 2022
@6543
Copy link
Member

6543 commented May 16, 2022

please resolve conflicts ;)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2022
delvh
delvh reviewed May 16, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflicts ;)

And the CI problems.

models/lfs.go Show resolved Hide resolved
models/repo/update.go Show resolved Hide resolved
services/repository/review.go Show resolved Hide resolved
services/repository/review.go Outdated Show resolved Hide resolved
services/repository/review.go Show resolved Hide resolved
services/repository/template.go Outdated Show resolved Hide resolved
services/repository/repository.go Show resolved Hide resolved
services/repository/hooks.go Outdated Show resolved Hide resolved
modules/repository/delete.go Outdated Show resolved Hide resolved
@lunny lunny force-pushed the lunny/repo_list branch 5 times, most recently from 7d4ac52 to 056bdd9 Compare May 23, 2022 11:29
@lunny lunny force-pushed the lunny/repo_list branch 2 times, most recently from a34b094 to 07c2054 Compare May 26, 2022 08:47
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@ebeb6e7). Click here to learn what that means.
The diff coverage is 69.06%.

@@           Coverage Diff           @@
##             main   #19711   +/-   ##
=======================================
  Coverage        ?   47.31%           
=======================================
  Files           ?      960           
  Lines           ?   133661           
  Branches        ?        0           
=======================================
  Hits            ?    63240           
  Misses          ?    62713           
  Partials        ?     7708
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
models/db/engine.go 32.65% <ø> (ø)
models/webhook/webhook.go 68.81% <0.00%> (ø)
modules/repository/init.go 51.92% <0.00%> (ø)
routers/web/explore/code.go 0.00% <0.00%> (ø)
routers/web/org/setting.go 0.00% <0.00%> (ø)
routers/web/repo/pull.go 31.23% <0.00%> (ø)
routers/web/repo/setting.go 15.94% <0.00%> (ø)
routers/web/repo/view.go 40.48% <0.00%> (ø)
routers/web/user/package.go 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebeb6e7...af3c0e5. Read the comment docs.

@lunny lunny requested review from noerw, wxiaoguang and delvh May 26, 2022 17:10
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2022
@lunny lunny mentioned this pull request Jun 3, 2022
Merged
wxiaoguang
wxiaoguang approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only hope is that there will be no rebase + force push after review starts, then I won't take the risk of code lost.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2022
@lunny lunny merged commit 2609511 into go-gitea:main Jun 6, 2022
@lunny lunny deleted the lunny/repo_list branch June 6, 2022 08:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 6, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
39c0dc7 
* giteaofficial/main:
  Move some repository related code into sub package (go-gitea#19711)
  A minimal change to replace data calls with attr as per guidelines (go-gitea#19900)
  Modernize JS build scripts (go-gitea#19824)
  [skip ci] Updated translations via Crowdin
  Update MAINTAINERS (go-gitea#19896)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @delvh @AbdulrhmnGhanem
Move some repository related code into sub package (go-gitea#19711)
86e30c6 
* Move some repository related code into sub package

* Move more repository functions out of models

* Fix lint

* Some performance optimization for webhooks and others

* some refactors

* Fix lint

* Fix

* Update modules/repository/delete.go

Co-authored-by: delvh <dev.lh@web.de>

* Fix test

* Merge

* Fix test

* Fix test

* Fix test

* Fix test

Co-authored-by: delvh <dev.lh@web.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@noerw noerw Awaiting requested review from noerw

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @6543 @codecov-commenter @wxiaoguang @delvh @GiteaBot