Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move checks for pulls before merge into own function (#19271) #19277

Merged
merged 10 commits into from
Mar 31, 2022
Merged

Move checks for pulls before merge into own function (#19271) #19277

merged 10 commits into from
Mar 31, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 31, 2022 •
edited
Loading

Backport #19271

Fix:

  • The API does ignore issue dependencies where Web does not
  • The API checks if "IsSignedIfRequired" where Web does not - UI probably do but nothing will some to craft custom requests
  • Default merge message is crafted a bit different between API and Web if not set on specific cases ...

@6543 6543 added the type/bug label Mar 31, 2022
@6543 6543 added this to the 1.16.6 milestone Mar 31, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2022
@6543 6543 changed the title Move checks for branchprotection into own package (#19271) Move checks for pulls before merge into own function (#19271) Mar 31, 2022
@6543 6543 merged commit 123c254 into go-gitea:release/v1.16 Mar 31, 2022
@6543 6543 deleted the backport_19271_single-place-to-enforce-protected-branch-rules branch March 31, 2022 14:57
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.6
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @wxiaoguang @GiteaBot