Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clone url JS error for the empty repo page #19209

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Fix clone url JS error for the empty repo page #19209

merged 3 commits into from
Mar 29, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 25, 2022 •
edited
Loading

The eslint-disable no-undef make the lint can not find the bug .....

Now we use a stable method to do the JS work

Fix:

@wxiaoguang wxiaoguang added this to the 1.16.6 milestone Mar 25, 2022
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 25, 2022
This was referenced Mar 25, 2022
Closed
Merged
@wxiaoguang wxiaoguang linked an issue Mar 25, 2022 that may be closed by this pull request
Please revert gidelines to create repo to use ssh origin link instead of http #19205
Closed
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 25, 2022
zeripath
zeripath approved these changes Mar 26, 2022
View reviewed changes
templates/repo/empty.tmpl Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2022
@6543
Copy link
Member

6543 commented Mar 29, 2022

note: pull to fix it in main is #19208

@lunny lunny merged commit b702f2d into go-gitea:release/v1.16 Mar 29, 2022
@wxiaoguang wxiaoguang deleted the fix-empty-repo-url branch March 29, 2022 03:18
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.6
Development

Successfully merging this pull request may close these issues.

Please revert gidelines to create repo to use ssh origin link instead of http
6 participants
@wxiaoguang @6543 @silverwind @zeripath @lunny @GiteaBot