Bump goldmark to v1.4.11 (#19201) #19203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noerw
approved these changes
Mar 24, 2022
GiteaBot
added
the
lgtm/need 1
|
CI fail is related: |
|
Let me fix this. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
I've added a testcase to prevent this from happening again. |
zeripath
approved these changes
Mar 24, 2022
|
Thanks! |
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #19201
Unfortunately goldmark 1.4.8 contains a bug whereby html comments on checklist elements are mistakenly rendered. This has been fixed upstream with goldmark 1.4.11.
Regression introduced in: #19127
Upstream issue: yuin/goldmark#285
Fix: #19195