Skip to content

Use custom favicon when viewing static files if it exists #19130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2022
Merged

Use custom favicon when viewing static files if it exists #19130

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d31b8aa
Use custom favicon when viewing static files if it exists
abheekda1 Mar 18, 2022
17217ce
Redirect to a favicon PNG that always exists
abheekda1 Mar 19, 2022
c76d789
Merge branch 'main' into custom-favicon-fix
abheekda1 Mar 19, 2022
0f8d7a2
Merge branch 'main' into custom-favicon-fix
zeripath Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions routers/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ func Routes(sessioner func(http.Handler) http.Handler) *web.Route {
http.Redirect(w, req, path.Join(setting.StaticURLPrefix, "/assets/img/apple-touch-icon.png"), 301)
})

// redirect default favicon to the path of the custom favicon with a default as a fallback
routes.Get("/favicon.ico", func(w http.ResponseWriter, req *http.Request) {
http.Redirect(w, req, path.Join(setting.StaticURLPrefix, "/assets/img/favicon.png"), 301)
})

common := []interface{}{}

if setting.EnableGzip {
Expand Down