Remove CodeMirror dependencies #18911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff is unfortunately spammed by all the file removals. There is only one actual file change in |
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/refactoring
Gusted
approved these changes
Feb 26, 2022
GiteaBot
added
lgtm/need 1
silverwind
removed
the
type/refactoring
|
|
1 and 2: It magically appears to work, but you are right there may be race conditions. I guess I will just make it sequentially load. The plugin itself accesses 3: CodeMirror's only purpose is to make EasyMDE work, I don't think we want to extend it further. |
silverwind
force-pushed
the
rm-codemirror
branch
from
789ea2f
to
b37e930
Compare
silverwind
changed the title
|
I ended up just removing the direct CodeMirror dependency altogether. EasyMDE already loads all the modes and plugins it needs, so there is no reason for neither the webpack dependency nor the vendored copy: Syntax highlighting in EasyMDE still works as expected. I suspect the reason why we left CodeMirror in was because it was previously in direct use by the code editor, which was replaced by monaco. |
wxiaoguang
approved these changes
Feb 26, 2022
GiteaBot
added
lgtm/done
|
Did anyone check if this breaks the Git Hooks editor? looks fine. |
|
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 27, 2022
* giteaofficial/main: Fix page and missing return on unadopted repos API (go-gitea#18848) [skip ci] Updated licenses and gitignores Allow adminstrator teams members to see other teams (go-gitea#18918) Update nginx reverse proxy docs (go-gitea#18922) Don't treat BOM escape sequence as hidden character. (go-gitea#18909) Remove CodeMirror dependencies (go-gitea#18911) Uncapitalize errors (go-gitea#18915) Disable service worker by default (go-gitea#18914) Set is_empty in fixtures (go-gitea#18869) Don't update email for organisation (go-gitea#18905) Correctly link URLs to users/repos with dashes, dots or underscores (go-gitea#18890) Set is_private in fixtures. (go-gitea#18868) Fix team management UI (go-gitea#18886) Update JS dependencies (go-gitea#18898) Fix migration v210 (go-gitea#18892) migrations: add test for importing pull requests in gitea uploader (go-gitea#18752)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
EasyMDE already loads all the modes and plugins it needs, so there is no reason for neither the webpack dependency nor the vendored copy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use webpack dynamic import to load the markdown mode for easymde, eliminating the need to ship the outdated vendored version of codemirror we had, while at the same time updating the markdown mode to the latest version too.
This should also bring a reduction in memory usage because we no long need to include all these unnecessary files in the bindata.
Solution is based on codemirror/codemirror5#5484.