Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock gofumpt to v0.3.0 and run it #18866

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 23, 2022

We can't depend on latest version of gofumpt because the output will not be stable across versions. Lock it down to the latest version released yesterday and run it again.

@silverwind silverwind changed the title Lock gofumpt to v0.0.3 and run it Lock gofumpt to v0.3.0 and run it Feb 23, 2022
We can't depend on `latest` version of gofumpt because the output will
not be stable across versions. Lock it down to the latest version
released yesterday and run it again.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2022
@silverwind
Copy link
Member Author

Followup on this topic: #18867

@silverwind silverwind added this to the 1.17.0 milestone Feb 23, 2022
@zeripath zeripath merged commit 2b9df56 into go-gitea:main Feb 23, 2022
@silverwind silverwind deleted the lock-gofumpt branch February 23, 2022 20:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2022
* giteaofficial/main:
  Fix ldap user sync missed email in email_address table (go-gitea#18786)
  Update assignees check to include any writing team and change org sidebar (go-gitea#18680)
  Set max text height to prevent overflow (go-gitea#18862)
  Lock gofumpt to v0.3.0 and run it (go-gitea#18866)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
We can't depend on `latest` version of gofumpt because the output will
not be stable across versions. Lock it down to the latest version
released yesterday and run it again.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants