Attempt to fix the webauthn migration again - part 3 #18770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
type/bug
backport/done
MariaDB now asserts that 408 characters is too long for a VARCHAR(410) I have no words. See go-gitea#18756 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
varchar-410-is-not-enough
branch
from
769f557
to
8c142c3
Compare
Codecov Report
@@ Coverage Diff @@
## main #18770 +/- ##
=======================================
Coverage ? 46.58%
=======================================
Files ? 852
Lines ? 122456
Branches ? 0
=======================================
Hits ? 57043
Misses ? 58529
Partials ? 6884
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
…o varchar-410-is-not-enough
fnetX
reviewed
Feb 15, 2022
zeripath
commented
Feb 15, 2022
|
I think this might actually still be insufficient. Is it possible that v208 might have updated the IDs to all be the same number too? If that's the case then this won't remigrate. Then there's the case of the users who have deleted the old u2f keys already too. |
lunny
reviewed
Feb 15, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
reviewed
Feb 15, 2022
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
…o varchar-410-is-not-enough
lunny
approved these changes
Feb 15, 2022
GiteaBot
added
lgtm/need 1
Signed-off-by: Andrew Thornton <art27@cantab.net>
fnetX
approved these changes
Feb 15, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
OK I think this is finally ready |
Gusted
approved these changes
Feb 16, 2022
GiteaBot
added
lgtm/done
zeripath
added a commit
that referenced
this pull request
Feb 16, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 17, 2022
* giteaofficial/main: Move deletebeans into models/db (go-gitea#18781) Allow mermaid render error to wrap (go-gitea#18790) Attempt to fix the webauthn migration again - part 3 (go-gitea#18770) Fix template bug of LFS lock (go-gitea#18784)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
v208.go is seriously broken as it misses an ID() check. We need to no-op and remigrate all of the u2f keys. See go-gitea#18756 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v208.go is seriously broken as it misses an ID() check. We need to no-op and remigrate all of the u2f keys.
See #18756
Signed-off-by: Andrew Thornton art27@cantab.net