Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forked repositories missed tags #18719

Merged
merged 5 commits into from
Feb 12, 2022
Merged

Fix forked repositories missed tags #18719

merged 5 commits into from
Feb 12, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 11, 2022

Fix #18715

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Feb 11, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b2b3225). Click here to learn what that means.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18719   +/-   ##
=======================================
  Coverage        ?   46.43%           
=======================================
  Files           ?      851           
  Lines           ?   121933           
  Branches        ?        0           
=======================================
  Hits            ?    56615           
  Misses          ?    58436           
  Partials        ?     6882
Impacted Files Coverage Δ
services/repository/fork.go 37.50% <20.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b3225...e9200a1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2022
zeripath
zeripath approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this really should be allowed to fail

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2022
@6543 6543 added this to the 1.17.0 milestone Feb 11, 2022
6543
6543 reviewed Feb 11, 2022
View reviewed changes
services/repository/fork.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2022
@lunny
Copy link
Member Author

lunny commented Feb 12, 2022

I'm not sure if this really should be allowed to fail

I have tried this, it will change more code than my predict. So I will keep this PR as it. I will open another PR to do that.

@lunny lunny merged commit 91ac65d into go-gitea:main Feb 12, 2022
@lunny lunny deleted the lunny/fix_fork_bug branch February 12, 2022 03:18
lunny added a commit to lunny/gitea that referenced this pull request Feb 12, 2022
@lunny @6543
Fix forked repositories missed tags (go-gitea#18719)
74790d3 
* Fix forked repositories missed tags

* Add missed close

* Use ctx

Co-authored-by: 6543 <6543@obermui.de>
@lunny lunny mentioned this pull request Feb 12, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 12, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 12, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
be1b906 
* giteaofficial/main:
  Send mail to issue/pr assignee/reviewer also when OnMention is set (go-gitea#18707)
  Reduce CI go module downloads, add make targets (go-gitea#18708)
  Add number in queue status to monitor page (go-gitea#18712)
  Fix source code line highlighting (go-gitea#18729)
  Fix forked repositories missed tags (go-gitea#18719)
  [skip ci] Updated translations via Crowdin
  Fix release typo (go-gitea#18728)
  Display template path of current page in dev mode (go-gitea#18717)
  Separate the details links of commit-statuses in headers (go-gitea#18661)
  Add LDAP group sync to Teams, fixes go-gitea#1395 (go-gitea#16299)
  Change git.cmd to RunWithContext (go-gitea#18693)
zeripath pushed a commit that referenced this pull request Feb 12, 2022
@lunny @6543
Fix forked repositories missed tags (#18719) (#18735)
9da8e47 
* Fix forked repositories missed tags

* Add missed close

* Use ctx

Co-authored-by: 6543 <6543@obermui.de>
Caellion added a commit to Caellion/gitea that referenced this pull request Feb 16, 2022
@Caellion
Merge branch 'main' of https://github.com/go-gitea/gitea
8adf230 
* 'main' of https://github.com/go-gitea/gitea: (87 commits)
  Fix template bug of LFS lock (go-gitea#18784)
  Various Mermaid improvements (go-gitea#18776)
  [skip ci] Updated translations via Crowdin
  Fix display time of milestones (go-gitea#18753)
  [skip ci] Updated translations via Crowdin
  Prevent dangling GetAttribute calls (go-gitea#18754)
  Add example to render html files (go-gitea#18736)
  Fix a broken link in `commits_list_small.tmpl` (go-gitea#18763)
  Fix broken cancel button link on patch page (go-gitea#18718)
  Ignore the migrate if u2f_registration is not exist (go-gitea#18760)
  [skip ci] Updated translations via Crowdin
  Increase the size of the webauthn_credential credential_id field 
(go-gitea#18739)
  Fix isempty detection of git repository (go-gitea#18746)
  [skip ci] Updated translations via Crowdin
  Send mail to issue/pr assignee/reviewer also when OnMention is set 
(go-gitea#18707)
  Reduce CI go module downloads, add make targets (go-gitea#18708)
  Add number in queue status to monitor page (go-gitea#18712)
  Fix source code line highlighting (go-gitea#18729)
  Fix forked repositories missed tags (go-gitea#18719)
  [skip ci] Updated translations via Crowdin
  ...
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @6543
Fix forked repositories missed tags (go-gitea#18719)
ddafae5 
* Fix forked repositories missed tags

* Add missed close

* Use ctx

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Tags and Releases missing after fork
5 participants
@lunny @codecov-commenter @zeripath @6543 @GiteaBot