Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webauthn nits #18284

Merged
merged 10 commits into from
Jan 15, 2022
Merged

Webauthn nits #18284

merged 10 commits into from
Jan 15, 2022

Conversation

zeripath
Copy link
Contributor

This PR contains some additional fixes and small nits related to #17957

@zeripath
Fix potential issue with case insensitive search for credential ID
b954dcb 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Restrict GetWebAuthnCredentialByCredID to user IDs
463f85f 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
handle errors slightly differently in the javascript
1298e55 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Adjust session names and ensure that webauthnName is deleted at the end
f24b4b2 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Remove unnecesary register device modal
3953c8a 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 15, 2022
@zeripath zeripath added this to the 1.16.0 milestone Jan 15, 2022
6543
6543 reviewed Jan 15, 2022
View reviewed changes
models/migrations/v207.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2022
@zeripath @wxiaoguang
Update options/locale/locale_en-US.ini
7cc3274 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zeripath
zeripath commented Jan 15, 2022
View reviewed changes
models/migrations/v207.go Outdated Show resolved Hide resolved
models/migrations/v207.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022 •
edited
Loading

Codecov Report

Merging #18284 (b7bdb66) into main (e239d35) will increase coverage by 0.00%.
The diff coverage is 6.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18284   +/-   ##
=======================================
  Coverage   45.74%   45.74%           
=======================================
  Files         831      831           
  Lines       92164    92165    +1     
=======================================
+ Hits        42159    42163    +4     
- Misses      43244    43245    +1     
+ Partials     6761     6757    -4
Impacted Files Coverage Δ
routers/web/auth/webauthn.go 0.00% <0.00%> (ø)
routers/web/user/setting/security/webauthn.go 0.00% <0.00%> (ø)
models/auth/webauthn.go 44.00% <16.66%> (ø)
modules/util/remove.go 48.00% <0.00%> (-8.00%) ⬇️
modules/queue/workerpool.go 50.00% <0.00%> (-3.06%) ⬇️
modules/process/manager.go 81.39% <0.00%> (-1.56%) ⬇️
modules/queue/queue_bytefifo.go 59.28% <0.00%> (-0.60%) ⬇️
services/pull/pull.go 41.70% <0.00%> (-0.41%) ⬇️
models/issue_comment.go 54.51% <0.00%> (+0.28%) ⬆️
routers/api/v1/repo/pull.go 28.85% <0.00%> (+0.50%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e239d35...b7bdb66. Read the comment docs.

@zeripath @wxiaoguang
Update web_src/js/features/user-auth-webauthn.js
b7bdb66 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2022
@6543 6543 merged commit d7c2a29 into go-gitea:main Jan 15, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 17, 2022
@zjjhot
Merge branch 'main' of https://github.com/go-gitea/gitea
0fae813 
* 'main' of https://github.com/go-gitea/gitea:
  show pull link for agit pull request also (go-gitea#18235)
  [skip ci] Updated translations via Crowdin
  Add some .ignore entries (go-gitea#18296)
  Remove unneeded debug messages to stdout. (go-gitea#18298)
  Handle missing default branch better in owner/repo/branches page (go-gitea#18290)
  Revert "Prevent possible XSS when using jQuery (go-gitea#18289)" (go-gitea#18293)
  not show double error response in git hook (go-gitea#18292)
  Remove accidental debugging in blob_excerpt.tmpl (go-gitea#18287)
  Prevent possible XSS when using jQuery (go-gitea#18289)
  Return nicer error if trying to pull from non-existent user (go-gitea#18288)
  [skip ci] Updated translations via Crowdin
  docs: mention client_max_body_size affects LFS (go-gitea#18291)
  Add lockfile-check (go-gitea#18285)
  Webauthn nits (go-gitea#18284)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath @6543 @wxiaoguang
Webauthn nits (go-gitea#18284)
2d01975 
This contains some additional fixes and small nits related to go-gitea#17957 

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@zeripath zeripath deleted the webauthn-2 branch December 29, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-commenter @wxiaoguang @6543 @GiteaBot