Skip to content

Fix correct usage of teams #17732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2021
Merged

Fix correct usage of teams #17732

merged 2 commits into from
Nov 20, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 19, 2021

  • .Teams isn't a field on the User type, thus using the seperate loaded teams.
  • Add a space between PathEscape and argument.

Fix correct usage of teams
c93f344 
- `.Teams` isn't a field on the User type, thus using the seperate
loaded teams.
- Add a space between `PathEscape` and argument.
@Gusted Gusted added this to the 1.16.0 milestone Nov 19, 2021
@Gusted
Copy link
Contributor Author

Gusted commented Nov 19, 2021

Regression from #17632

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021 •
edited
Loading

Codecov Report

Merging #17732 (81a3a80) into main (a85e75b) will increase coverage by 0.06%.
The diff coverage is 63.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17732      +/-   ##
==========================================
+ Coverage   45.44%   45.50%   +0.06%     
==========================================
  Files         802      805       +3     
  Lines       89233    89743     +510     
==========================================
+ Hits        40556    40842     +286     
- Misses      42140    42361     +221     
- Partials     6537     6540       +3
Impacted Files Coverage Δ
cmd/migrate_storage.go 0.00% <0.00%> (ø)
models/error.go 38.62% <0.00%> (-0.19%) ⬇️
models/issue_list.go 71.80% <0.00%> (ø)
models/issue_lock.go 0.00% <0.00%> (ø)
models/statistic.go 0.00% <0.00%> (ø)
models/user.go 56.63% <ø> (-0.06%) ⬇️
modules/doctor/dbconsistency.go 6.83% <0.00%> (ø)
modules/doctor/storage.go 21.27% <0.00%> (ø)
routers/api/v1/org/hook.go 0.00% <0.00%> (ø)
routers/api/v1/org/team.go 35.86% <0.00%> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52869ef...81a3a80. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2021
@lunny lunny merged commit 9f14fe4 into go-gitea:main Nov 20, 2021
@Gusted Gusted deleted the Fix-teams branch November 24, 2021 08:26
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix correct usage of teams (go-gitea#17732)
142cd71 
- `.Teams` isn't a field on the User type, thus using the seperate
loaded teams.
- Add a space between `PathEscape` and argument.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Gusted @codecov-commenter @lunny @wxiaoguang @GiteaBot