-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stats upon searching issues #17566
Conversation
- Fixes a issue whereby the given chunk of issueIDs wasn't respected and thus the returned results where not the correct results.
Could you add some tests? |
Done. |
Codecov Report
@@ Coverage Diff @@
## main #17566 +/- ##
=======================================
Coverage ? 45.51%
=======================================
Files ? 793
Lines ? 88846
Branches ? 0
=======================================
Hits ? 40439
Misses ? 41891
Partials ? 6516
Continue to review full report at Codecov.
|
Maybe this should be backport to v1.15 |
|
- Backport of #17566 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
* Fix stat chunks searching - Fixes a issue whereby the given chunk of issueIDs wasn't respected and thus the returned results where not the correct results. * Add tests Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
thus the returned results where not the correct results. More specifically when the amount of returned results are above
maxQueryParameters
.To reproduce this issue easily:
maxQueryParameters
within the code to a value of5
.Hello
).Hello
.^ This PR fixes that issue.
Their is a interesting comment above the relevant code:
gitea/models/issue.go
Lines 1502 to 1505 in bd613c7
I do think that the person writing that comment was hitting into this bug whereby the wrong issuesIDs were used in the database action and I do think it can be removed, but I'm not sure.
Screenshots(The repo had 7 issues with the description of
Helo
):Before:
After: