Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix email with + when active #17518

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 2, 2021

Fix #17516

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17518 (3c8eb3d) into main (cb9c818) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17518      +/-   ##
==========================================
+ Coverage   45.49%   45.51%   +0.01%     
==========================================
  Files         793      793              
  Lines       88766    88766              
==========================================
+ Hits        40385    40401      +16     
+ Misses      41868    41855      -13     
+ Partials     6513     6510       -3     
Impacted Files Coverage Δ
modules/templates/helper.go 51.02% <ø> (ø)
services/pull/pull.go 41.78% <0.00%> (ø)
modules/queue/queue_bytefifo.go 59.88% <0.00%> (+0.59%) ⬆️
modules/queue/workerpool.go 48.09% <0.00%> (+1.52%) ⬆️
modules/queue/queue_disk_channel.go 62.72% <0.00%> (+1.77%) ⬆️
modules/log/event.go 62.50% <0.00%> (+1.85%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9c818...3c8eb3d. Read the comment docs.

@zeripath zeripath merged commit e69521f into go-gitea:main Nov 2, 2021
@zeripath
Copy link
Contributor

zeripath commented Nov 2, 2021

Please send backport

@lunny lunny deleted the lunny/fix_email_active branch November 2, 2021 11:51
lunny added a commit to lunny/gitea that referenced this pull request Nov 2, 2021
Co-authored-by: zeripath <art27@cantab.net>
@lunny lunny added the backport/done All backports for this PR have been created label Nov 2, 2021
lafriks pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: zeripath <art27@cantab.net>
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 22, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add secondary email address to acount containing a "+" character
7 participants