API: don't allow merged PRs to be reopened #17192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
reviewed
Sep 30, 2021
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Oct 1, 2021
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Oct 2, 2021
This comment has been minimized.
This comment has been minimized.
|
Please send back port to v1.15 |
GiteaBot
added
lgtm/done
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Oct 15, 2021
* api: dont open merged PRs * don't change base branch when already merged * don't allow any state change * also validate opening merged PRs in EditIssue Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #17180
I tried to add tests, but didn't find a way to merge a pull request without introducing a race condition in testing (
pr.CanAutoMerge()blocks merging right away). If you have any hints, I'll add tests