Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.15 fix Sprintf format 'verbs' in locale files #17187

Merged
merged 2 commits into from
Sep 30, 2021
Merged

v1.15 fix Sprintf format 'verbs' in locale files #17187

merged 2 commits into from
Sep 30, 2021

Conversation

axifive
Copy link
Member

@axifive axifive commented Sep 29, 2021

as title

@axifive
fix sprintf verbs in locales
b56cfe2 
Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
@delvh
Copy link
Member

delvh commented Sep 29, 2021

If I understand the Crowdin Process correctly, this PR is unnecessary as it will be overwritten by Crowdin with the next "update translations" commit.
The best way would then be to fix it manually in Crowdin for each of these locales.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 29, 2021
@axifive
Copy link
Member Author

axifive commented Sep 29, 2021 •
edited
Loading

If I understand the Crowdin Process correctly, this PR is unnecessary as it will be overwritten by Crowdin with the next "update translations" commit.
The best way would then be to fix it manually in Crowdin for each of these locales.

As far as I know it will be overwritten by Crowdin only on main branch.

@delvh delvh added this to the 1.15.4 milestone Sep 29, 2021
@6543
Copy link
Member

6543 commented Sep 29, 2021 •
edited
Loading

yes crowdin update only happen on main

@6543
Copy link
Member

6543 commented Sep 29, 2021

was it fixed on crowdin for main?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 29, 2021
@axifive
Copy link
Member Author

axifive commented Sep 29, 2021 •
edited
Loading

was it fixed on crowdin for main?

No, Only Russian locale

delvh
delvh approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the rest.
You apparently took care of the russian translations.

options/locale/locale_de-DE.ini Show resolved Hide resolved
options/locale/locale_es-ES.ini Show resolved Hide resolved
options/locale/locale_nl-NL.ini Show resolved Hide resolved
options/locale/locale_uk-UA.ini Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Sep 30, 2021

It's for v1.15, so the backport label is not necessary.

@lunny
Copy link
Member

lunny commented Sep 30, 2021 •
edited
Loading

make L-G-T-M work. @delvh hm, It seems your approval hasn't been counted.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2021
@lunny lunny merged commit bf6264c into go-gitea:release/v1.15 Sep 30, 2021
@axifive axifive deleted the v1.15_fix_locales_verbs branch September 30, 2021 05:36
@delvh
Copy link
Member

delvh commented Sep 30, 2021

@lunny I know.
That bot seems broken.
No matter what I do, it does not count my approvals.
I've already accepted my fate.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick left review comments

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Milestone
1.15.4
Development

Successfully merging this pull request may close these issues.
6 participants
@axifive @delvh @6543 @lunny @techknowlogick @GiteaBot