Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing repo link in issue/pull assigned emails (#17183) #17184

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 29, 2021

Backport #17183

There was a mistake in the template file: templates/mail/issue/assigned.tmpl
where the repourl was generated from a non-existent release instead of the issue.

This PR changes this to use the issue but also ensure that the issue repo is loaded.

It also slightly improves the English and the Russian locale string.

Fix #17160

Signed-off-by: Andrew Thornton art27@cantab.net

Backport go-gitea#17183

There was a mistake in the template file: `templates/mail/issue/assigned.tmpl`
where the repourl was generated from a non-existent release instead of the issue.

This PR changes this to use the issue but also ensure that the issue repo is loaded.

It also slightly improves the English locale string.

Fix go-gitea#17160

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.15.4 milestone Sep 29, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 29, 2021
services/mailer/mail.go Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Sep 29, 2021

🚀

@6543 6543 merged commit 5b6b7e7 into go-gitea:release/v1.15 Sep 29, 2021
@zeripath zeripath deleted the backport-17183-1.15 branch September 30, 2021 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants