Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic in Org mode HighlightCodeBlock #17140

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

zeripath
Copy link
Contributor

When rendering source in org mode there is a mistake in the highlight code that
causes a panic.

This PR fixes this.

Fix #17139

Signed-off-by: Andrew Thornton art27@cantab.net

When rendering source in org mode there is a mistake in the highlight code that
causes a panic.

This PR fixes this.

Fix go-gitea#17139

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.16.0 milestone Sep 24, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Sep 24, 2021
Backport go-gitea#17140

When rendering source in org mode there is a mistake in the highlight code that
causes a panic.

This PR fixes this.

Fix go-gitea#17139

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 24, 2021
modules/highlight/highlight.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2021
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit 623d2dd into go-gitea:main Sep 24, 2021
@zeripath zeripath deleted the fix-17139-prevent-panic-in-org-mode branch September 24, 2021 13:29
zeripath added a commit that referenced this pull request Sep 24, 2021
Backport #17140

When rendering source in org mode there is a mistake in the highlight code that
causes a panic.

This PR fixes this.

Fix #17139

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Sep 27, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org snippet caused 500 internal server error
5 participants