Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136) #17137

Merged
merged 8 commits into from
Sep 27, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 23, 2021

Backport #17136

There was a serious issue with the gitea dump command in 1.14.3-1.14.6 which led to corruption of the config field of the repo_unit table.

This PR adds a doctor command to attempt to fix the broken repo_units. Users affected by #16961 should run:

gitea doctor --fix --run fix-broken-repo-units

Fix #16961
Fix #17297

Signed-off-by: Andrew Thornton art27@cantab.net

Backport go-gitea#17136

Unfortunately a number of people appear to have been bitten by the bug in the dump
command.

This PR adds a doctor command to attempt to fix the broken repo_units

Fix go-gitea#16961

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.15.4 milestone Sep 23, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/changelog Adds the changelog for a new Gitea version label Sep 27, 2021
@zeripath zeripath changed the title WIP: Add repounit fixer for #16961 (#17136) Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136) Sep 27, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 27, 2021
modules/doctor/fix16961_test.go Outdated Show resolved Hide resolved
modules/doctor/fix16961.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2021
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit 4b8b214 into go-gitea:release/v1.15 Sep 27, 2021
@zeripath zeripath deleted the backport-17136 branch September 27, 2021 17:30
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants