-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added URL mapping for Release attachments like on github.com #1707
Added URL mapping for Release attachments like on github.com #1707
Conversation
If this doesn't pass then I'm not giving anything more! |
@gdeverlant would you be able to resolve conflicts as well as update per @lafriks's suggestion? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
==========================================
- Coverage 37.82% 37.81% -0.02%
==========================================
Files 322 322
Lines 47498 47544 +46
==========================================
+ Hits 17966 17977 +11
- Misses 26944 26982 +38
+ Partials 2588 2585 -3
Continue to review full report at Codecov.
|
Forgive me for bothering, but I'm just trying to understand: What exactly does this PR do? I'm not able to understand clearly. We already have releases with attachments, don't we? |
@rakshith-ravi it provides clean URLs for attachments (has filename in URL), instead of the URL being the UUID of the uploaded file. |
Implement a Git Hub style URL mapping for the attachment files in Release.