Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL mapping for Release attachments like on github.com #1707

Conversation

al-sabr
Copy link
Contributor

@al-sabr al-sabr commented May 11, 2017

Implement a Git Hub style URL mapping for the attachment files in Release.

image

models/attachment.go Outdated Show resolved Hide resolved
@appleboy appleboy added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 12, 2017
@al-sabr
Copy link
Contributor Author

al-sabr commented May 12, 2017

If this doesn't pass then I'm not giving anything more!

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2017
modules/util/file.go Outdated Show resolved Hide resolved
@lunny lunny added this to the 1.3.0 milestone Jun 18, 2017
@lunny lunny modified the milestones: 1.3.0, 1.x.x Oct 11, 2017
@techknowlogick
Copy link
Member

@gdeverlant would you be able to resolve conflicts as well as update per @lafriks's suggestion?

@stale
Copy link

stale bot commented Jan 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 4, 2019
@stale stale bot removed the issue/stale label Jan 6, 2019
@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #1707 into master will decrease coverage by 0.01%.
The diff coverage is 4.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   37.82%   37.81%   -0.02%     
==========================================
  Files         322      322              
  Lines       47498    47544      +46     
==========================================
+ Hits        17966    17977      +11     
- Misses      26944    26982      +38     
+ Partials     2588     2585       -3
Impacted Files Coverage Δ
routers/repo/repo.go 20.82% <0%> (-1.94%) ⬇️
models/attachment.go 43.62% <0%> (-3.48%) ⬇️
models/release.go 52.8% <0%> (-0.96%) ⬇️
routers/routes/routes.go 85.01% <100%> (+0.04%) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
models/repo_indexer.go 48.3% <0%> (+3.81%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd006db...926e486. Read the comment docs.

@techknowlogick techknowlogick modified the milestones: 1.x.x, 1.8.0 Jan 6, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2019
@techknowlogick techknowlogick merged commit d3dc07f into go-gitea:master Jan 6, 2019
@rakshith-ravi
Copy link
Contributor

Forgive me for bothering, but I'm just trying to understand: What exactly does this PR do? I'm not able to understand clearly. We already have releases with attachments, don't we?

@techknowlogick
Copy link
Member

@rakshith-ravi it provides clean URLs for attachments (has filename in URL), instead of the URL being the UUID of the uploaded file.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants