Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond with updated notifications in API #17064

Merged

Conversation

noerw
Copy link
Member

@noerw noerw commented Sep 15, 2021

The 'mark notification as X' APIs previously had empty responses.
This change makes them return the notifications affected by the request.
fixes #16797

@noerw noerw added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Sep 15, 2021
@noerw noerw added this to the 1.16.0 milestone Sep 15, 2021
@codecov-commenter

This comment has been minimized.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 16, 2021
@lunny lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Sep 16, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 17, 2021
@techknowlogick techknowlogick merged commit 0ffad31 into go-gitea:main Sep 17, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@zeripath zeripath changed the title Notifications API: respond with updated notifications Respond with updated notifications in API Jan 18, 2022
@6543 6543 deleted the better-notifications-api-responses branch April 26, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notifications write-APIs should return the modified notifications
7 participants