remove sqlite tag when integration test with mysql/postgres and recreate database when init integration test #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate database when init integration test
bkcsoft
reviewed
May 8, 2017
| if _, err = db.Exec("CREATE DATABASE testgitea"); err != nil { | ||
| log.Fatalf("db.Exec: %v", err) | ||
| if rows.Next() { | ||
| if _, err = db.Exec("DROP DATABASE testgitea"); err != nil { |
There was a problem hiding this comment.
When run on drone it's no need. But when run make test-mysql local, it will failed when you run twice because the old data didn't cleanup. This change will drop the old database and load data from *.yml file.
|
Apart from the comment, LGTM |
tboerger
added
the
lgtm/need 2
|
make LG-TM work |
tboerger
added
lgtm/need 1
|
Will it continue to work if user has no rights to drop database? |
|
@lafriks No, but if they don't they probably don't have rights to create databases as well (previous test created the DB...) |
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. This will spend less time when run
test-mysqlandtest-pgsqlsince there is no CGO build.