Clean-up HookPreReceive and restore functionality for pushing non-standard refs #16705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
type/bug
type/refactoring
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 16, 2021
…#16705) Partial Backport go-gitea#16705 There was an inadvertent breaking change in go-gitea#15629 meaning that notes refs and other git extension refs will be automatically rejected. This PR removes this incorrect forced rejection of non-standard refs. Fix go-gitea#16688 Signed-off-by: Andrew Thornton <art27@cantab.net>
…ndard refs There was an inadvertent breaking change in go-gitea#15629 meaning that notes refs and other git extension refs will be automatically rejected. Further following go-gitea#14295 and go-gitea#15629 the pre-recieve hook code is untenably long and too complex. This PR refactors the hook code and removes the incorrect forced rejection of non-standard refs. Fix go-gitea#16688 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-16688-clean-up-pre-receive
branch
from
521fdfb to
cbe8dbe
Compare
|
Tests fail |
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Aug 17, 2021
GiteaBot
added
lgtm/need 1
|
Code looks good but tests fail: |
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-16688-clean-up-pre-receive
branch
from
5ba2382 to
f14b465
Compare
a1012112796
reviewed
Aug 17, 2021
| // internal routes | ||
|
|
||
| // RepoAssignment assigns the repository and gitrepository to the private context | ||
| func RepoAssignment(ctx *gitea_context.PrivateContext) context.CancelFunc { |
There was a problem hiding this comment.
I will rebase my PR if this merged at first.
There was a problem hiding this comment.
We can always change Lunny's PR to make the PrivateContext have a less complicated and simpler Repo context.
This comment has been minimized.
This comment has been minimized.
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Aug 24, 2021
…#16705) (go-gitea#16706) Partial Backport go-gitea#16705 There was an inadvertent breaking change in go-gitea#15629 meaning that notes refs and other git extension refs will be automatically rejected. This PR removes this incorrect forced rejection of non-standard refs. Fix go-gitea#16688 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Peeps this needs to be merged to restore functionality for git notes and others |
Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Sep 15, 2021
6543
approved these changes
Sep 16, 2021
GiteaBot
added
lgtm/done
|
thanks for the great work, I confirm the notes functionality is back for me 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an inadvertent breaking change in #15629 meaning that notes refs and other
git extension refs will be automatically rejected.
Further following #14295 and #15629 the pre-recieve hook code is untenably long and
too complex.
This PR refactors the hook code and removes the incorrect forced rejection of
non-standard refs.
Fix #16688
Signed-off-by: Andrew Thornton art27@cantab.net