Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate csv import in modules/csv/csv.go #16631

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

richmahn
Copy link
Contributor

@richmahn richmahn commented Aug 5, 2021

Remove the unnecessary duplicate package import for encoding/csv in modules/csv/csv.go

Fix #16557

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 5, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Aug 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 5, 2021
@zeripath zeripath changed the title Fixes #16557 - duplicate csv import Remove duplicate csv import in modules/csv/csv.go Aug 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16631 (432d48c) into main (19e2c6a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16631   +/-   ##
=======================================
  Coverage   45.35%   45.35%           
=======================================
  Files         750      750           
  Lines       85115    85115           
=======================================
+ Hits        38605    38606    +1     
+ Misses      40264    40262    -2     
- Partials     6246     6247    +1     
Impacted Files Coverage Δ
modules/csv/csv.go 75.92% <0.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/log/event.go 60.64% <0.00%> (-1.86%) ⬇️
routers/web/repo/view.go 41.52% <0.00%> (+0.57%) ⬆️
modules/queue/workerpool.go 53.81% <0.00%> (+0.76%) ⬆️
modules/git/blame.go 67.14% <0.00%> (+1.42%) ⬆️
models/unit.go 43.83% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1332c...432d48c. Read the comment docs.

@zeripath zeripath merged commit fd39e6d into go-gitea:main Aug 5, 2021
@richmahn richmahn deleted the richmahn-16557-csv-import branch August 9, 2021 14:44
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV module includes encoding/csv twice
5 participants