Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump: Add option to skip LFS/attachment files #15407

Merged
merged 3 commits into from
Apr 12, 2021
Merged

dump: Add option to skip LFS/attachment files #15407

merged 3 commits into from
Apr 12, 2021

Conversation

johanvdw
Copy link
Contributor

Currently, it is not possible to skip LFS/attachment files when using dump.
As our repository contains some very large LFS files, we prefer to backup these separate from the rest of the repo.

@johanvdw johanvdw changed the title Add option to skip dumping LFS/attachment files dump: Add option to skip LFS/attachment files Apr 11, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 11, 2021
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Apr 11, 2021
@zeripath zeripath added this to the 1.15.0 milestone Apr 11, 2021
@zeripath
Copy link
Contributor

I'm not averse to suggesting this be backported to v1.14 as it's relatively self-contained.

@zeripath
Copy link
Contributor

In the meantime - you could set the attachments/lfs storage configuration to something temporary to avoid these things being dumped.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2021
@lunny lunny merged commit 6d2866f into go-gitea:master Apr 12, 2021
zeripath pushed a commit to zeripath/gitea that referenced this pull request Apr 15, 2021
@johanvdw @lunny @zeripath
dump: Add option to skip LFS/attachment files (go-gitea#15407)
218e9c8 
Backport go-gitea#15407

* Add option to skip dumping LFS/attachment files

* Fix fmt issues

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@zeripath zeripath mentioned this pull request Apr 15, 2021
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Apr 15, 2021
lafriks added a commit that referenced this pull request Apr 15, 2021
@zeripath @johanvdw
@lunny @lafriks
dump: Add option to skip LFS/attachment files (#15407) (#15492)
802a431 
Backport #15407

* Add option to skip dumping LFS/attachment files

* Fix fmt issues

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: Johan Van de Wauw <johan@gisky.be>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
aswild added a commit to aswild/gitea that referenced this pull request May 3, 2021
@aswild
Merge tag 'v1.14.1' into wild/v1.14
717e81a 
v1.14.1

* BUGFIXES
  * Fix bug clone wiki (go-gitea#15499) (go-gitea#15502)
  * Github Migration ignore rate limit, if not enabled (go-gitea#15490) (go-gitea#15495)
  * Use subdir for URL (go-gitea#15446) (go-gitea#15493)
  * Query the DB for the hash before inserting in to email_hash (go-gitea#15457) (go-gitea#15491)
  * Ensure review dismissal only dismisses the correct review (go-gitea#15477) (go-gitea#15489)
  * Use index of the supported tags to choose user lang (go-gitea#15452) (go-gitea#15488)
  * Fix wrong file link in code search page (go-gitea#15466) (go-gitea#15486)
  * Quick template fix for built-in SSH server in admin config (go-gitea#15464) (go-gitea#15481)
  * Prevent superfluous response.WriteHeader (go-gitea#15456) (go-gitea#15476)
  * Fix ambiguous argument error on tags (go-gitea#15432) (go-gitea#15474)
  * Add created_unix instead of expiry to migration (go-gitea#15458) (go-gitea#15463)
  * Fix repository search (go-gitea#15428) (go-gitea#15442)
  * Prevent NPE on avatar direct rendering if federated avatars disabled (go-gitea#15434) (go-gitea#15439)
  * Fix wiki clone urls (go-gitea#15430) (go-gitea#15431)
  * Fix dingtalk icon url at webhook (go-gitea#15417) (go-gitea#15426)
  * Standardise icon on projects PR page (go-gitea#15387) (go-gitea#15408)
* ENHANCEMENTS
  * Add option to skip LFS/attachment files for `dump` (go-gitea#15407) (go-gitea#15492)
  * Clone panel fixes (go-gitea#15436)
  * Use semantic dropdown for code search query type (go-gitea#15276) (go-gitea#15364)
* BUILD
  * Build go-git variants for windows (go-gitea#15482) (go-gitea#15487)
  * Lock down build-images dependencies (Partial go-gitea#15479) (go-gitea#15480)
* MISC
  * Performance improvement for list pull requests (go-gitea#15447) (go-gitea#15500)
  * Fix potential copy lfs records failure when fork a repository (go-gitea#15441) (go-gitea#15485)
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@johanvdw @zeripath @lunny @6543 @GiteaBot