Redirect on bad CSRF instead of presenting bad page #14937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Hmm, this certainly improves UE greatly, but I don't think merging this should close that issue entirely (although that issue lacks details for further investigation to take place). |
GiteaBot
added
the
lgtm/need 2
|
But the submitted form information will be lost. Before we can click |
jpraet
approved these changes
Jun 30, 2021
GiteaBot
added
lgtm/need 1
The back button still works for me. |
6543
approved these changes
Jul 8, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #14937 +/- ##
==========================================
- Coverage 45.51% 45.51% -0.01%
==========================================
Files 709 709
Lines 83755 83767 +12
==========================================
+ Hits 38120 38124 +4
- Misses 39500 39508 +8
Partials 6135 6135
Continue to review full report at Codecov.
|
|
I think it's better to back port to v1.14 |
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Jul 8, 2021
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <art27@cantab.net>
|
-> #16378 |
6543
added a commit
that referenced
this pull request
Jul 8, 2021
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages I think we can be a little kinder and redirect to base page with a flash error Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CSRF handler is a bit harsh with bad CSRF tokens on webpages
I think we can be a little kinder and redirect to base page with a flash error
Fix #14167
Signed-off-by: Andrew Thornton art27@cantab.net