-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment-to-ini to docker image #14762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the one README change, could you also update the Gitea Docker docs to mention using these changes?
a557390
to
f956ee9
Compare
Codecov Report
@@ Coverage Diff @@
## master #14762 +/- ##
==========================================
- Coverage 42.21% 42.21% -0.01%
==========================================
Files 767 771 +4
Lines 81624 82078 +454
==========================================
+ Hits 34458 34647 +189
- Misses 41531 41784 +253
- Partials 5635 5647 +12
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!!
68a51ec
to
f4c6be8
Compare
Thanks for this work but this needs to be made optional. When deploying Gitea using docker swarm, you pass the |
Something conditional to be wrapped around:
|
@decentral1se can you open a new issue and reference this pull, else its likely to get lost in the void |
The question of how to support automated deployment configs has come up a lot lately with many different solutions, so I'd like to add official support for the environment-to-ini util function.
I've added it to the docker build and call it in the docker setup function. Note that I have it outside of the
[ ! -f ${GITEA_CUSTOM}/conf/app.ini ]
check so that it is run every time the container is started.If there is support for this I can add a section to https://docs.gitea.io/en-us/install-with-docker/