Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge default and system webhooks under one menu #14244

Merged
merged 6 commits into from
Jan 14, 2021

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 4, 2021

Before:
image

After:
image

@lafriks lafriks added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jan 4, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 4, 2021
routers/repo/webhook.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 4, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 5, 2021
@lunny
Copy link
Member

lunny commented Jan 14, 2021

@lafriks Please update

@lafriks
Copy link
Member Author

lafriks commented Jan 14, 2021

@lunny done :)

@codecov-io
Copy link

codecov-io commented Jan 14, 2021

Codecov Report

Merging #14244 (d0a71be) into master (84b147c) will decrease coverage by 0.00%.
The diff coverage is 24.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14244      +/-   ##
==========================================
- Coverage   41.85%   41.85%   -0.01%     
==========================================
  Files         744      744              
  Lines       79639    79638       -1     
==========================================
- Hits        33335    33331       -4     
  Misses      40816    40816              
- Partials     5488     5491       +3     
Impacted Files Coverage Δ
models/webhook.go 71.20% <0.00%> (+2.13%) ⬆️
routers/admin/hooks.go 0.00% <0.00%> (ø)
routers/org/setting.go 0.00% <0.00%> (ø)
routers/repo/webhook.go 1.16% <6.25%> (+0.12%) ⬆️
routers/routes/macaron.go 93.24% <100.00%> (+0.01%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 57.95% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b147c...d0a71be. Read the comment docs.

@lafriks
Copy link
Member Author

lafriks commented Jan 14, 2021

🚀

@lafriks lafriks merged commit 6eee9f0 into go-gitea:master Jan 14, 2021
@lafriks lafriks deleted the fix/system_webhooks_menu branch January 14, 2021 23:24
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants