Skip to content

Check for notExist on profile repository page #14197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2020
Merged

Check for notExist on profile repository page #14197

merged 1 commit into from
Dec 31, 2020

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 30, 2020 •
edited
Loading

Fix #14189

@zeripath zeripath added this to the 1.14.0 milestone Dec 30, 2020
@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #14197 (148b039) into master (632800e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14197      +/-   ##
==========================================
+ Coverage   42.00%   42.01%   +0.01%     
==========================================
  Files         733      733              
  Lines       78713    78715       +2     
==========================================
+ Hits        33061    33071      +10     
+ Misses      40218    40212       -6     
+ Partials     5434     5432       -2
Impacted Files Coverage Δ
routers/user/setting/profile.go 38.88% <0.00%> (-0.44%) ⬇️
routers/api/v1/repo/pull.go 25.45% <0.00%> (+0.60%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
modules/queue/manager.go 65.08% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 632800e...148b039. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2020
@lunny lunny merged commit ef825bd into go-gitea:master Dec 31, 2020
@lunny
Copy link
Member

lunny commented Dec 31, 2020

Please send backport

@zeripath zeripath deleted the fix-14189-notexisterr branch December 31, 2020 10:39
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 31, 2020
@zeripath
Check for notExist on profile repository page (go-gitea#14197)
b31b3da 
Backport go-gitea#14197

Fix go-gitea#14189
@zeripath zeripath mentioned this pull request Dec 31, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 31, 2020
lunny pushed a commit that referenced this pull request Dec 31, 2020
@zeripath
Check for notExist on profile repository page (#14197) (#14203)
58c105d 
Backport #14197

Fix #14189
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Settings->Repositories causing "500" error if the user (the user is an admin) has not created/owned any repository

5 participants

@zeripath @codecov-io @lunny @techknowlogick @GiteaBot