Consolidate Logos and update README header #14136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
pr/breaking
silverwind
commented
Dec 23, 2020
GiteaBot
added
the
lgtm/need 2
silverwind
force-pushed
the
lessicons
branch
from
0b94aa9 to
25e96c6
Compare
- Remove unused `logo-lg.png`, `logo-sm.png` and `logo-192.png`. - Consolidate `favicon.svg` and `logo.svg` to just `logo.svg`. - Remove Safari Mask icon, it seems to work fine with just `favicon.png` (no SVG support). - Remove Fluid Icon. It only served Firefox and SVG works just fine there. - Update customization instructions. - Update README.md to use SVG icon, increase logo size and center it and badges.
silverwind
force-pushed
the
lessicons
branch
from
25e96c6 to
566e1fa
Compare
Merged
lunny
reviewed
Dec 25, 2020
lunny
approved these changes
Dec 25, 2020
GiteaBot
added
lgtm/need 1
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind
commented
Dec 25, 2020
Member
Author
|
Note that some sources say that a 192px icon is required for the Homescreen icon on Android but I just tested with 512px only and it seems to work just as well, so I think we can keep it to the one raster size in the manifest. |
Member
Author
|
Also tested with mobile Firefox and it reveals what is most likely a Firefox bug, see mozilla-mobile/fenix#17215. |
techknowlogick
approved these changes
Jan 1, 2021
GiteaBot
added
lgtm/done
Member
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logo-lg.png,logo-sm.pngandlogo-192.png.favicon.svgandlogo.svgto justlogo.svg.favicon.pngworks just fine since Safari 12.