Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent type of HookTask.Typ #14128

Closed
wants to merge 2 commits into from
Closed

Conversation

donlon
Copy link
Contributor

@donlon donlon commented Dec 23, 2020

Webhook type has been changed to string (CHAR(16)) in #13664 and will be synced to the database, but this field in webhook.go has not. This may result in ...rm/session_schema.go:339:Sync2() [W] Table hook_task column typ db type is CHAR(16), struct type is VARCHAR(255) error and failure quries.

@codecov-io
Copy link

Codecov Report

Merging #14128 (0f34fb9) into master (e0c753e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14128      +/-   ##
==========================================
- Coverage   42.37%   42.36%   -0.02%     
==========================================
  Files         726      726              
  Lines       77839    77839              
==========================================
- Hits        32982    32973       -9     
- Misses      39447    39453       +6     
- Partials     5410     5413       +3     
Impacted Files Coverage Δ
models/webhook.go 69.06% <ø> (ø)
modules/git/tree_entry_nogogit.go 87.50% <0.00%> (-6.25%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/queue/manager.go 62.13% <0.00%> (-2.96%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.90% <0.00%> (-0.73%) ⬇️
routers/api/v1/repo/pull.go 24.84% <0.00%> (-0.61%) ⬇️
modules/git/utils.go 80.55% <0.00%> (+2.77%) ⬆️
modules/indexer/stats/db.go 56.00% <0.00%> (+8.00%) ⬆️
modules/git/repo_base_nogogit.go 72.72% <0.00%> (+9.09%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c753e...0f34fb9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 23, 2020
@lunny
Copy link
Member

lunny commented Dec 23, 2020

We need a migration and also varchar maybe better than my previous change.

@donlon
Copy link
Contributor Author

donlon commented Dec 25, 2020

We need a migration and also varchar maybe better than my previous change.

@lunny I've seen the changes you made on it. I'll close this pr as it's not useful anymore.

@donlon donlon closed this Dec 25, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants