Skip to content

Send webhook when tag is removed via Web UI #14015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2020
Merged

Send webhook when tag is removed via Web UI #14015

merged 2 commits into from
Dec 16, 2020

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Dec 16, 2020

Fixes #14000

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 16, 2020
@lunny lunny added the type/bug label Dec 16, 2020
@lunny lunny added this to the 1.14.0 milestone Dec 16, 2020
@codecov-io
Copy link

codecov-io commented Dec 16, 2020 •
edited
Loading

Codecov Report

Merging #14015 (ffd3959) into master (66379ba) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14015      +/-   ##
==========================================
+ Coverage   42.20%   42.23%   +0.02%     
==========================================
  Files         710      710              
  Lines       77273    77281       +8     
==========================================
+ Hits        32612    32637      +25     
+ Misses      39288    39274      -14     
+ Partials     5373     5370       -3
Impacted Files Coverage Δ
services/release/release.go 48.59% <100.00%> (+4.15%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/pull.go 40.68% <0.00%> (-0.50%) ⬇️
models/error.go 38.98% <0.00%> (ø)
models/issue_comment.go 52.87% <0.00%> (+0.15%) ⬆️
modules/git/repo.go 46.23% <0.00%> (+0.50%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66379ba...ffd3959. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 16, 2020
@jolheiser jolheiser merged commit 53308de into go-gitea:master Dec 16, 2020
@jolheiser
Copy link
Member

jolheiser commented Dec 16, 2020

@CirnoT Backport is a go. ✈️

@CirnoT CirnoT deleted the deltag-webui-hook branch December 16, 2020 16:20
CirnoT added a commit to CirnoT/gitea that referenced this pull request Dec 16, 2020
@CirnoT
Send webhook when tag is removed via Web UI (go-gitea#14015)
34d66af 
* Send webhook when tag is removed via Web UI

* Stray code

(cherry picked from commit 53308de)
6543 pushed a commit that referenced this pull request Dec 16, 2020
@CirnoT
Send webhook when tag is removed via Web UI (#14015) (#14019)
90dfe44 
* Send webhook when tag is removed via Web UI

* Stray code (cherry picked from commit 53308de)

* Fix for 1.13
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Webhook not triggered when tag is removed via web UI

7 participants

@CirnoT @codecov-io @jolheiser @lunny @a1012112796 @zeripath @GiteaBot