-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support shortened commit SHAs in URLs #13686
Support shortened commit SHAs in URLs #13686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13686 +/- ##
==========================================
- Coverage 42.27% 42.26% -0.02%
==========================================
Files 697 697
Lines 76616 76618 +2
==========================================
- Hits 32389 32380 -9
- Misses 38908 38915 +7
- Partials 5319 5323 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from other PR:
Can we support the shortened sha but redirect to the full actual one ?
@techknowlogick I don't think that's needed as it does kind of break desired behavior imho and other (ex. Github and Gitlab) also does not do redirection |
hmm redirection could be a feature ... |
Also we don't do redirection also in other places where we already support short sha urls. Also if later added to API it would be even undesirable |
In that case is it possible to add |
9003d75
to
d0ea927
Compare
@techknowlogick it's not fool proof but added :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
🚀 |
Fixes #6450
Closes #6452